Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for PBKDF2 keystore generation #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aimxhaisse
Copy link

No description provided.

@aimxhaisse aimxhaisse closed this May 15, 2023
@aimxhaisse aimxhaisse deleted the pbkdf2-format branch May 15, 2023 14:33
@aimxhaisse aimxhaisse restored the pbkdf2-format branch May 15, 2023 14:39
@CarlBeek
Copy link
Collaborator

I'm happy to expose PBKDF2, but I'd prefer it be hidden behind a --pbkdf2 flag as opposed to --key_format. Also why did you close this PR?

@CarlBeek CarlBeek reopened this May 15, 2023
@aimxhaisse aimxhaisse force-pushed the pbkdf2-format branch 3 times, most recently from b4f5e51 to 65cb37b Compare June 20, 2023 19:53
@aimxhaisse
Copy link
Author

Gently ping :)

@aimxhaisse
Copy link
Author

Recent example where this could have helped a bit: to generate 100 000 of keys for the Holesky network for folks part of the genesis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants