Remove one SSZ seralization layer from ping extensions + clean up rest of spec #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeme
reviewed
Jan 20, 2025
KolbyML
force-pushed
the
clean-up-ping-ext-one-less-layer
branch
from
ef4d1bd to
060d75d
Compare
|
I applied the feedback 🚀 |
kdeme
approved these changes
Jan 20, 2025
KolbyML
force-pushed
the
clean-up-ping-ext-one-less-layer
branch
from
060d75d to
f64cff0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I basically just expand on Kim's PR and flesh out the rest of it so it aligns with his idea of removing the extra SSZ serialization layer