Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing IOAct which was not used #630

Merged
merged 1 commit into from
Jan 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- We now try to simplify expressions fully before trying to cast them to a concrete value
This should improve issues when "Unexpected Symbolic Arguments to Opcode" was
unnecessarily output
- Removed dead code related to IOAct in the now deprecated and removed debugger

## [0.54.2] - 2024-12-12

Expand Down
10 changes: 0 additions & 10 deletions src/EVM/Stepper.hs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ module EVM.Stepper
, wait
, ask
, evm
, evmIO
, enter
, interpret
)
Expand Down Expand Up @@ -49,9 +48,6 @@ data Action t s a where
-- | Embed a VM state transformation
EVM :: EVM t s a -> Action t s a

-- | Perform an IO action
IOAct :: IO a -> Action t s a

-- | Type alias for an operational monad of @Action@
type Stepper t s a = Program (Action t s) a

Expand All @@ -72,9 +68,6 @@ ask = singleton . Ask
evm :: EVM t s a -> Stepper t s a
evm = singleton . EVM

evmIO :: IO a -> Stepper t s a
evmIO = singleton . IOAct

-- | Run the VM until final result, resolving all queries
execFully :: Stepper Concrete s (Either EvmError (Expr Buf))
execFully =
Expand Down Expand Up @@ -121,9 +114,6 @@ interpret fetcher vm = eval . view
m <- fetcher q
vm' <- liftIO $ stToIO $ execStateT m vm
interpret fetcher vm' (k ())
IOAct m -> do
r <- liftIO m
interpret fetcher vm (k r)
EVM m -> do
(r, vm') <- liftIO $ stToIO $ runStateT m vm
interpret fetcher vm' (k r)
3 changes: 0 additions & 3 deletions src/EVM/SymExec.hs
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,6 @@ interpret fetcher maxIter askSmtIters heuristic vm =
Stepper.Exec -> do
(r, vm') <- liftIO $ stToIO $ runStateT exec vm
interpret fetcher maxIter askSmtIters heuristic vm' (k r)
Stepper.IOAct q -> do
r <- liftIO q
interpret fetcher maxIter askSmtIters heuristic vm (k r)
Stepper.Ask (PleaseChoosePath cond continue) -> do
frozen <- liftIO $ stToIO $ freezeVM vm
evalLeft <- toIO $ do
Expand Down
2 changes: 0 additions & 2 deletions test/EVM/Test/Tracing.hs
Original file line number Diff line number Diff line change
Expand Up @@ -581,8 +581,6 @@ interpretWithTrace fetcher =
vm' <- liftIO $ stToIO $ State.execStateT m vm
assign _1 vm'
interpretWithTrace fetcher (k ())
Stepper.IOAct q ->
liftIO q >>= interpretWithTrace fetcher . k
Stepper.EVM m -> do
vm <- use _1
(r, vm') <- liftIO $ stToIO $ State.runStateT m vm
Expand Down
Loading