Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups in preparation of GHC 9.8 #612

Merged
merged 6 commits into from
Jan 2, 2025
Merged

Conversation

elopez
Copy link
Collaborator

@elopez elopez commented Dec 5, 2024

Description

This PR does a few cleanups to reduce the number of warnings/errors when compiling with GHC 9.8

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@elopez elopez force-pushed the ghc-9.8 branch 2 times, most recently from 5aff2f6 to 53bccde Compare December 5, 2024 18:28
@elopez elopez force-pushed the ghc-9.8 branch 2 times, most recently from ab1ae8e to 5268c77 Compare December 27, 2024 13:48
@elopez elopez changed the title Build hevm with GHC 9.8 Cleanups in preparation of GHC 9.8 Dec 27, 2024
@elopez elopez marked this pull request as ready for review December 31, 2024 09:15
Copy link
Collaborator

@msooseth msooseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice, thanks! LGTM -- did you check the warning about

Module ‘Data.Aeson’ does not export ‘json’

@elopez
Copy link
Collaborator Author

elopez commented Jan 2, 2025

@msooseth Yeah, older aeson versions export json and we have a variable called that all around the file, so it needs hiding. But the newer versions don't have it anymore, so it produces that warning. I can't remove the hiding ... or it would break the build for older versions of aeson. Maybe we can bump the min aeson version to something higher? I think I tried that and it failed for a different reason but I can't recall the specifics now; give it a try if you can 😄

@elopez
Copy link
Collaborator Author

elopez commented Jan 2, 2025

I was hoping to update nixpkgs further as well but currently z3 is broken: NixOS/nixpkgs#327052

@msooseth
Copy link
Collaborator

msooseth commented Jan 2, 2025

Ahhhh okay, that makes sense regarding the hiding. Sad that Z3 is broken. Thanks, merging!

@msooseth msooseth merged commit 1ee4453 into ethereum:main Jan 2, 2025
10 checks passed
@numinit
Copy link

numinit commented Jan 2, 2025

I'm hoping that should be merged soon. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants