Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DeleteAtStem command for state rollbacks #446
add DeleteAtStem command for state rollbacks #446
Changes from 1 commit
4d1f76a
b9f52b9
7dc5142
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a copy/paste from the
Delete(...)
API, but I guess we could try extracting the logic to a private method?And BTW, there's a typo (that already existed before). L680, "algorigthm"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to do that right off the bat, but it's making the interface more complicated. I'd like to do that too, but I want to ensure correctness.
One of the differences, as you pointed out, is what happens when you delete something that doesn't exist. Since this is meant to be called from something that knows of reverse-diffs, so if the value does not exist, there is an issue somewhere.