trie: Change the algorithm that converts a trie commitment to 32 bytes #29010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
commented
Feb 17, 2024
kevaundray
commented
Feb 17, 2024
Comment on lines
-309
to
-313
| // The output of Byte() is big endian for banderwagon. This | ||
| // introduces an imbalance in the tree, because hashes are | ||
| // elements of a 253-bit field. This means more than half the | ||
| // tree would be empty. To avoid this problem, use a little | ||
| // endian commitment and chop the MSB. |
There was a problem hiding this comment.
This comment about big endian doesn't apply anymore since MapToScalarFieldBytes returns its output in Little endian
|
One thought while modifying the library: If go-verkle exposes a The |
kevaundray
force-pushed
the
kw/remove-usage-of-dot-bytes-method
branch
from
6017345 to
2f75c12
Compare
kevaundray
changed the title
|
Closing as this has been opened up in guillaumes fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Initially this PR was aiming to move us towards one way of converting a point to a 32 byte slice. Unfortunately, we need the Serialize/Deserialize method when converting the root node to a 32 byte slice. So we only change pedersenHash to use
MapToScalarFieldBytesRationale
This issue specifies most of the rationale: crate-crypto/rust-verkle#86
As its currently written, this PR is not technically blocked by ethereum/go-verkle#428 -- If that PR gets merged, then we can replace a method that I've temporarily duplicated