Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): fix address padding in extcall tests #1117

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix(tests): fix address padding in extcall tests #1117

merged 1 commit into from
Jan 23, 2025

Conversation

chfast
Copy link
Member

@chfast chfast commented Jan 23, 2025

🗒️ Description

Simplify and properly convert bytes to Address using left_padding.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast
fix(tests): fix address padding in extcall tests
1bc1525 
Simplify and properly convert bytes to `Address` using `left_padding`.
@chfast chfast force-pushed the fix_extcode_tests branch from ed4abd0 to 1bc1525 Compare January 23, 2025 15:50
marioevz
marioevz approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit b20cf5a into ethereum:main Jan 23, 2025
11 checks passed
@marioevz marioevz deleted the fix_extcode_tests branch January 23, 2025 16:25
fselmo pushed a commit to fselmo/execution-spec-tests that referenced this pull request Jan 24, 2025
@chfast @fselmo
fix(tests): fix address padding in extcall tests (ethereum#1117)
bd771a0 
Simplify and properly convert bytes to `Address` using `left_padding`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

@shemnon shemnon shemnon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chfast @shemnon @marioevz