[Jovian] Add specs for consensus event nonces (deposits + config changes) #487
+269
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
mdehoog
force-pushed
the
michael/event-nonce
branch
3 times, most recently
from
2fc26ec to
43d952e
Compare
mdehoog
commented
Jan 4, 2025
| @@ -38,8 +38,8 @@ The overall calldata layout is as follows: | |||
| | l1BlockHash | bytes32 | 100-131 | 4 | | |||
| | batcherHash | bytes32 | 132-163 | 5 | | |||
|
|
|||
| Total calldata length MUST be exactly 164 bytes, implying the sixth and final segment is only | |||
There was a problem hiding this comment.
This may have been applicable to an earlier version of the ecotone calldata, but it was updated to only have 5 segments, and they are all full.
mdehoog
requested review from
protolambda,
sebastianst,
ajsutton,
tynes and
mslipper
as code owners
mdehoog
changed the title
mdehoog
force-pushed
the
michael/event-nonce
branch
2 times, most recently
from
e413ee9 to
f570238
Compare
mdehoog
force-pushed
the
michael/event-nonce
branch
from
f570238 to
51576e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add specs for #330 (comment).
Tracker issue: ethereum-optimism/optimism#13543
Additional context
We're excited to get this change out as we see it as a precursor to #478, which is useful for our L3s.