-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AppStream): Added metadata XML listing supported hardware (ESPTOOL-983) #1046
feat(AppStream): Added metadata XML listing supported hardware (ESPTOOL-983) #1046
Conversation
👋 Hello petterreinholdtsen, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
This allow programs like isenkram to map relevant hardware to this package, and propose to install the package when supported hardware is available. The XML file is installed in /usr/share/metainfo/.
e6a14b6
to
065c207
Compare
Thanks for the contribution! We appreciate the effort you’ve put into this. Unfortunately, there are several reasons why we don’t plan to support this:
We hope you understand our decision not to include this patch. Thanks again for your contribution. Radim |
[Radim Karniš]
Unfortunately, there are several reasons why we don’t plan to support
this:
Sad to hear this.
Note, I believe my proposed list of modalias entries listed is based on
the entires in the udev rules defined on Debian, where the driver
cdc_acm list these entries according to '/sbin/modinfo cdc_acm'. It
provide a simple and automatic way to update the list.
In any case, thank you for letting me know about your rationale. I
guess the esptool package will not join the currently 113 and growing
packages in Debian prividing hardware mappings with AppStream making it
possible to automatically propose the package when relevant hardware is
present. Who knows, it might change some day in the future. :)
…--
Happy hacking
Petter Reinholdtsen
|
This sounds pretty much to me something which could be better generated/maintained on the Debian side. And the resulting file applied as a post-installation patch. Just for future readers I'd like to point out that esptool has a filtering capability (https://docs.espressif.com/projects/esptool/en/latest/esp32/esptool/advanced-options.html#filtering-serial-ports) which can be used to achieve something similar. VID:PID-based filters can be defined which will narrow down ports during finding the right serial ports among the available ones. I know it is not the same as the purpose of the PR. |
This allow programs like isenkram to map relevant hardware to this package, and propose to install the package when supported hardware is available.
This patch was originally submitted to Debian as https://bugs.debian.org/1079458 .
The change is not tested, I do not own any relevant hardware myself. (NO TESTING)