-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(esp32c5): Add stub flasher support #5
Conversation
👋 Hello Dzarda7, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
@dobairoland PTAL |
Changes LGTM. I would like to rebase this after #6 and compare the JSON file from the artifacts with the one from the esptool repository. |
@Dzarda7 Could you please rebase this? Not all github actions were started here (my mistake!). I've created and merged a fix in the meantime. |
@dobairoland done. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @Dzarda7.
I also checked that the binaries from the artifacts are the same as the ones in the latest esptool master branch (C5 and C5beta3 included).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Overview
This pull request adds stub support for ESP32C5. It adds both UART and USB-serial/JTAG stub support. The support was already added into esptool recently.
Related
Relates to ESPTOOL-825