Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esp32c5): Add stub flasher support #5

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

Dzarda7
Copy link
Contributor

@Dzarda7 Dzarda7 commented Jul 9, 2024

Overview

This pull request adds stub support for ESP32C5. It adds both UART and USB-serial/JTAG stub support. The support was already added into esptool recently.

Related

Relates to ESPTOOL-825

Copy link

github-actions bot commented Jul 9, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello Dzarda7, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 8db7a40

@Dzarda7
Copy link
Contributor Author

Dzarda7 commented Jul 9, 2024

@dobairoland PTAL

@dobairoland
Copy link
Collaborator

Changes LGTM. I would like to rebase this after #6 and compare the JSON file from the artifacts with the one from the esptool repository.

@dobairoland
Copy link
Collaborator

@Dzarda7 Could you please rebase this? Not all github actions were started here (my mistake!). I've created and merged a fix in the meantime.

@Dzarda7
Copy link
Contributor Author

Dzarda7 commented Jul 10, 2024

@dobairoland done. Thanks.

@dobairoland dobairoland self-requested a review July 10, 2024 06:42
Copy link
Collaborator

@dobairoland dobairoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @Dzarda7.

I also checked that the binaries from the artifacts are the same as the ones in the latest esptool master branch (C5 and C5beta3 included).

Copy link
Collaborator

@peterdragun peterdragun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@radimkarnis radimkarnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@dobairoland dobairoland merged commit 3a8f92d into espressif:master Jul 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants