Fix performance regression in debug logging from win32 protobuf crash…

… workaround (#940)
esphome · Aug 29, 2024 · fce8922 · fce8922
1 parent 059af0e
commit fce8922
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/aioesphomeapi/connection.pxd b/aioesphomeapi/connection.pxd
@@ -12,6 +12,7 @@ cdef float KEEP_ALIVE_TIMEOUT_RATIO
 cdef object HANDSHAKE_TIMEOUT
 
 cdef bint TYPE_CHECKING
+cdef bint _WIN32
 
 cdef object WRITE_EXCEPTIONS
 

diff --git a/aioesphomeapi/connection.py b/aioesphomeapi/connection.py
@@ -101,6 +101,7 @@
 
 WRITE_EXCEPTIONS = (RuntimeError, ConnectionResetError, OSError)
 
+_WIN32 = sys.platform == "win32"
 
 _int = int
 _bytes = bytes
@@ -719,7 +720,7 @@ def send_messages(self, msgs: tuple[message.Message, ...]) -> None:
                     # calling __str__ on the message may crash on
                     # Windows systems due to a bug in the protobuf library
                     # so we call MessageToDict instead
-                    MessageToDict(msg),
+                    MessageToDict(msg) if _WIN32 else msg,
                 )
 
         if TYPE_CHECKING:
@@ -921,7 +922,7 @@ def process_packet(self, msg_type_proto: _int, data: _bytes) -> None:
                 # calling __str__ on the message may crash on
                 # Windows systems due to a bug in the protobuf library
                 # so we call MessageToDict instead
-                MessageToDict(msg),
+                MessageToDict(msg) if _WIN32 else msg,
             )
 
         if self._pong_timer is not None: