-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wifi power-save mode #17
Open
ForsakenHarmony
wants to merge
1
commit into
esp-rs:master
Choose a base branch
from
ForsakenHarmony:wifi-power-save
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -216,6 +216,25 @@ pub struct EspWifi { | |
shared: Box<EspMutex<Shared>>, | ||
} | ||
|
||
pub enum PowerSaveMode { | ||
/// No power save | ||
None, | ||
/// Minimum modem power saving. In this mode, station wakes up to receive beacon every DTIM period | ||
MinModem, | ||
///Maximum modem power saving. In this mode, interval to receive beacons is determined by the listen_interval parameter in wifi_sta_config_t | ||
MaxModem, | ||
} | ||
|
||
impl Into<wifi_ps_type_t> for PowerSaveMode { | ||
fn into(self) -> wifi_ps_type_t { | ||
match self { | ||
PowerSaveMode::None => wifi_ps_type_t_WIFI_PS_NONE, | ||
PowerSaveMode::MinModem => wifi_ps_type_t_WIFI_PS_MIN_MODEM, | ||
PowerSaveMode::MaxModem => wifi_ps_type_t_WIFI_PS_MAX_MODEM, | ||
} | ||
} | ||
} | ||
|
||
impl EspWifi { | ||
pub fn new( | ||
netif_stack: Arc<EspNetifStack>, | ||
|
@@ -301,6 +320,10 @@ impl EspWifi { | |
Ok(wifi) | ||
} | ||
|
||
pub fn set_power_save_mode(&mut self, mode: PowerSaveMode) -> Result<(), EspError> { | ||
esp!(unsafe { esp_wifi_set_ps(mode.into()) }) | ||
} | ||
|
||
pub fn with_client_netif<F, T>(&self, f: F) -> T | ||
where | ||
F: FnOnce(Option<&EspNetif>) -> T, | ||
|
@@ -828,7 +851,7 @@ impl Drop for EspWifi { | |
fn drop(&mut self) { | ||
unsafe { | ||
TAKEN.lock(|taken| { | ||
self.clear_all().unwrap(); | ||
// self.clear_all().unwrap(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Forgotten debugging code? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. most likely, I think I ran into a crash related to this, but I don't remember for sure |
||
*taken = false; | ||
}); | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for symmetry, perhaps implement also
get_power_safe_mode
?