Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wifi power-save mode #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/wifi.rs
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,25 @@ pub struct EspWifi {
shared: Box<EspMutex<Shared>>,
}

pub enum PowerSaveMode {
/// No power save
None,
/// Minimum modem power saving. In this mode, station wakes up to receive beacon every DTIM period
MinModem,
///Maximum modem power saving. In this mode, interval to receive beacons is determined by the listen_interval parameter in wifi_sta_config_t
MaxModem,
}

impl Into<wifi_ps_type_t> for PowerSaveMode {
fn into(self) -> wifi_ps_type_t {
match self {
PowerSaveMode::None => wifi_ps_type_t_WIFI_PS_NONE,
PowerSaveMode::MinModem => wifi_ps_type_t_WIFI_PS_MIN_MODEM,
PowerSaveMode::MaxModem => wifi_ps_type_t_WIFI_PS_MAX_MODEM,
}
}
}

impl EspWifi {
pub fn new(
netif_stack: Arc<EspNetifStack>,
Expand Down Expand Up @@ -301,6 +320,10 @@ impl EspWifi {
Ok(wifi)
}

pub fn set_power_save_mode(&mut self, mode: PowerSaveMode) -> Result<(), EspError> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for symmetry, perhaps implement also get_power_safe_mode?

esp!(unsafe { esp_wifi_set_ps(mode.into()) })
}

pub fn with_client_netif<F, T>(&self, f: F) -> T
where
F: FnOnce(Option<&EspNetif>) -> T,
Expand Down Expand Up @@ -828,7 +851,7 @@ impl Drop for EspWifi {
fn drop(&mut self) {
unsafe {
TAKEN.lock(|taken| {
self.clear_all().unwrap();
// self.clear_all().unwrap();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgotten debugging code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most likely, I think I ran into a crash related to this, but I don't remember for sure

*taken = false;
});
}
Expand Down