Add DataSchema, docs, tests, config improvements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have put an Apache license in this repo, should I change it to some other? |
|
Also in regards to testing, I am thinking about expanding the scope of it, because as of now, tests are based on one or 2 different messages, but what can be done is to gather subset of different messages and then doing something similar to property based testing, but I would need to come up with some way of handling comparison between mapping output and expected output for adding new cases and so on |
erszcz
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Great work, @luk-pau-es 🚀
I've left a few comments - some just as notes for the future, but some would be good to address still in this PR. This thing looks good!
This was referenced Dec 12, 2024
|
Looks good! 🎉 |
erszcz
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DataSchema for mapping XML to Elixir structures
Add tests
Configuration improvements
Add new message handlers
Add message Mapper
Add docs and ensure docs generated with mix docs (ExDoc) are correct
Add License
Add proper readme
Setup GH Actions for Elixir
Add .tool-versions