Fix partial heap sort #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `partialSortByBounds` had an off-by-one error causing all the partial heap sort functions to produce incorrect results. The off-by-one error was fixed and the `prop_partialsort` property test was updated to catch this error. Testing the code before the change fails, while after the change passes. Closes: #46
erikd
force-pushed
the
erikd/partial-sort
branch
from
e358592 to
8ca487e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
partialSortByBoundshad an off-by-one error causing all the partial heap sort functions to produce incorrect results.The off-by-one error was fixed and the
prop_partialsortproperty test was updated to catch this error. Testing the code before the change fails, while after the change passes.#46