Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First steps to migrate to sublime text 3 #22

Closed
wants to merge 1 commit into from
Closed

First steps to migrate to sublime text 3 #22

wants to merge 1 commit into from

Conversation

rdeangelis83
Copy link

Hi Eric,

I hope you're feeling better :)

I have started to make some changes so that the plugin is now working in Sublime-Text-3.

I know it is by far not perfect but must of the feature are working again in Sublime-Text-3 :)

BR
Rocco

@maheshjag
Copy link

@rdeangelis83 you may find that my pull request (#17) contains very similar changes :-)

@rdeangelis83
Copy link
Author

@maheshjag Yep looks very similar :)
But I have seen that you only decode the result of the subprocess but whats about the error?
e.g. WarnUser(err.strip()) does this work without decode?

@ericmartel
Copy link
Owner

Hi guys,

Sorry for the time it took for me to reply, but please check the Sublime-Text-3-Perforce-Plugin repo for all things ST3. Considering the name of the repo it wouldn't make sense to change it for ST3 while potentially breaking the ST2 integration.

Thanks! :)

@rdeangelis83
Copy link
Author

LOL -> First Commit -> 2 months ago :)

@maheshjag
Copy link

@rdeangelis83 Yes, it seemed to work without decode. But then again, my use of the plugin isn't extensive.

Thanks @ericmartel, I'm going to look up the other repo tomorrow. Super work!

@rdeangelis83 rdeangelis83 closed this by deleting the head repository Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants