BSD/GNU portability fixes. #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In GNU sed regular expressions '\|' is an extension even when not using extended syntax, so use '[|]' to match a single pipe character. This should work on all platforms as expected. GNU mktemp needs at least 3 X's in the template. md5 is not available on GNU/Linux out of the box, so use md5sum or md5, whichever is present. Also removed some unnecessary backslash escapes.
|
Fantastic! Thanks for the PR. I will try to take a look at this sometime this week and get it merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Eric,
I really liked this project, especially in conjunction with zsh-autosuggestions that you have significantly improved lately (thanks for that!), so I made it work on GNU systems as well. I could not test on OS X, but it should now work on both.
Bests,
Geza