ENH: add a method that creates a grid property between two input surfaces #1291
Conversation
| @@ -5,7 +5,7 @@ ignore_missing_imports = True | |||
| strict_equality = True | |||
| warn_redundant_casts = True | |||
| warn_unused_configs = True | |||
| warn_unused_ignores = True | |||
| warn_unused_ignores = False | |||
There was a problem hiding this comment.
Changed this as it seems that mypy messages are incorrect (the # type: ignore is needed, but mypy claims it is not)
There was a problem hiding this comment.
Just an aside, but I've found this usually to happen when some imports are not quite right in some way
| } | ||
| } | ||
| return std::make_tuple(xmid, ymid, zmid); | ||
| } |
There was a problem hiding this comment.
As a note, manual testing indicates that this function in pybind11 is 2-3 times faster than the corresponding function using swig (which it now replaces).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1291 +/- ##
==========================================
+ Coverage 80.02% 81.12% +1.09%
==========================================
Files 98 94 -4
Lines 13680 12480 -1200
Branches 2203 1882 -321
==========================================
- Hits 10948 10124 -824
+ Misses 1999 1692 -307
+ Partials 733 664 -69 ☔ View full report in Codecov by Sentry. |
jcrivenaes
force-pushed
the
grd3d-flag-between-surfs
branch
from
a3088c7 to
54b549f
Compare
| @@ -5,7 +5,7 @@ ignore_missing_imports = True | |||
| strict_equality = True | |||
| warn_redundant_casts = True | |||
| warn_unused_configs = True | |||
| warn_unused_ignores = True | |||
| warn_unused_ignores = False | |||
There was a problem hiding this comment.
Just an aside, but I've found this usually to happen when some imports are not quite right in some way
src/xtgeo/grid3d/_grid_etc1.py
Outdated
| is_discrete = True | ||
|
|
||
| if isinstance(value, float): | ||
| array = array.astype(float) * value |
There was a problem hiding this comment.
If array is an py::array<bool> I think this should be a bit more performant as well
jcrivenaes
force-pushed
the
grd3d-flag-between-surfs
branch
from
fd3f8b5 to
272bcbb
Compare
Solves #1290 as derived task from https://github.com/equinor/fmu-orion-playground/issues/19
Contributes also to #1247