Rename job configuration files #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lars-petter-hauge
force-pushed
the
rename_config_files
branch
from
f6f574c to
a631c7b
Compare
libres will look for an executable in the same folder as the job configuration file is located. If the name of the config is the same as the name of the executable, libres will be confused. The usual standard in ERT would be to capitalize the config file. On OSX systems, which are case-insensitive, this isn't viable. The job config files are therefore appended with "_CONFIG". The jobs will be installed as JOB_NAME JOB_NAME_CONFIG, and the JOB_NAME_CONFIG will point to an executable named job_name - which we install with entry-points. The user can use the forward model job as normal: SIMULATION_JOB JOB_NAME
lars-petter-hauge
force-pushed
the
rename_config_files
branch
from
a631c7b to
ff6891f
Compare
|
New issues spawned from this PR: #354 |
oyvindeide
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #306
libres will look for an executable in the same folder as the job
configuration file is located. If the name of the config is the same as
the name of the executable, libres will be confused. The usual standard
in ERT would be to capitalize the config file. On OSX systems, which are
case-insensitive, this isn't viable. The job config files are therefore
appended with "_CONFIG". The jobs will be installed as JOB_NAME
JOB_NAME_CONFIG, and the JOB_NAME_CONFIG will point to an executable
named job_name - which we install with entry-points. The user can use
the forward model job as normal: SIMULATION_JOB JOB_NAME