Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid certain symlinks when checking for inconsistencies #513

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Oct 2, 2024

Resolves #512

We have altered how symlinks are being interpreted when introducing multiple rhel-versions, and when introducing bleeding-timestamped builds.
The concept of root-link does not fully match here, where we source symlinks based on OS versions in enable scripts, and therefore have no clean linkage as we used to have.

@andreas-el andreas-el force-pushed the resolve_reported_symlink_inconsistencies branch from 5ff07fe to 90cd496 Compare October 2, 2024 12:27
@andreas-el andreas-el changed the title Resolve reported symlink inconsistencies Avoid certain symlinks when checking for consistencies Oct 2, 2024
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

consider moving the pull request text into one of the two commit messages?

@andreas-el andreas-el merged commit 0b12037 into main Oct 3, 2024
5 checks passed
@andreas-el andreas-el deleted the resolve_reported_symlink_inconsistencies branch October 3, 2024 07:58
@andreas-el andreas-el changed the title Avoid certain symlinks when checking for consistencies Avoid certain symlinks when checking for inconsistencies Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Komodo check symlinks fail on new timestamped bleeding builds
2 participants