Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove latest package alias feature #506

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Conversation

larsevj
Copy link
Collaborator

@larsevj larsevj commented Jul 3, 2024

  • Pip 24.1 removed the legacy feature that the get_latest_pypi_version functionality depended on. We therefore remove this functionality as it is currently only used by 2 packages.
  • Also removes the shell pypi package from dependencies. This seems to be a wrapper around subprocess, and I cannot find a usage of it ever in the history of komodo. The package also has not been updated in 7 years.

@larsevj
Copy link
Collaborator Author

larsevj commented Jul 4, 2024

There is the question of if we want to guard against usage of the "*" package version and fail gracefully. I vote no, since for our usage we control the versions specified in a komodo release.

larsevj added 2 commits July 4, 2024 14:57
The pip functionality that it relied on has been removed.
Will remove this feature since it does not seem to be much in use.
@larsevj larsevj force-pushed the remove_latest_package_alias branch from 34af8f0 to 472eab0 Compare July 4, 2024 12:57
@larsevj larsevj requested a review from andreas-el July 4, 2024 14:42
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper work! 🌴

@larsevj larsevj merged commit e0b8c43 into main Jul 5, 2024
5 checks passed
@larsevj larsevj deleted the remove_latest_package_alias branch July 5, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants