Add flag for ignoring entries check pypi script #387
Conversation
jonathan-eq
force-pushed
the
add-flag-for-ignoring-entrie-check-pypi-script
branch
2 times, most recently
from
57656f7 to
7fcfe34
Compare
jonathan-eq
force-pushed
the
add-flag-for-ignoring-entrie-check-pypi-script
branch
3 times, most recently
from
ac92823 to
29aecb1
Compare
jonathan-eq
force-pushed
the
add-flag-for-ignoring-entrie-check-pypi-script
branch
from
29aecb1 to
bcc4d65
Compare
| try: | ||
| current_version = get_version.Version(versions["previous"]) | ||
| except get_version.InvalidVersion: | ||
| print(f"Could not parse version {versions['previous']}") |
There was a problem hiding this comment.
This is now printouts we will get if we have "main" as version but not filtered them out?
There was a problem hiding this comment.
It's been too long to remember, but can this create noise in the output? main is an accepted version in bleeding.
There was a problem hiding this comment.
Yes, but this only runs on packages which have pypi as a source in repository.yml. Main versions are sourced elsewhere, so it is filtered out at an earlier stage.
There was a problem hiding this comment.
^usually sourced with git
jonathan-eq
force-pushed
the
add-flag-for-ignoring-entrie-check-pypi-script
branch
5 times, most recently
from
c11b4ba to
6c3e25f
Compare
Added argument flag for ignoring package_name/package_version from getting upgrade suggestions using regex.
jonathan-eq
force-pushed
the
add-flag-for-ignoring-entrie-check-pypi-script
branch
from
6c3e25f to
992f1f2
Compare
|
There is another issue with the code. It skips versions marked as pre-release, but certain packages only have pre-release versions. In this case, it will try to run max() over an empty list and fail. |
This commits adds a check to see if any valid pypi package versions were found. If not, it will let the user know that the package should be checked manually.
Resolves #342
Resolves #414
Depends on #386