Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(person): personselect should now clear on setting selectedPerson … #1650

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(person): personselect should now clear on setting selectedPerson … #1650

merged 1 commit into from
Nov 20, 2024

Conversation

eikeland
Copy link
Contributor

Changes in PersonSelectController

  • Renamed the attrSelectPerson method to attrSelectedPerson.
  • Updated the attrSelectedPerson method to clear selectedIds when select is null or an empty string and selectedIds size is greater than zero.
  • Added logic to clear previous selections when the selectedPerson property changes.

Changes in PersonSelectElement

  • Updated the updated method to call attrSelectedPerson instead of attrSelectPerson.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: dc48a1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@equinor/fusion-wc-person Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eikeland eikeland marked this pull request as draft November 19, 2024 13:47
@eikeland eikeland self-assigned this Nov 19, 2024
@eikeland eikeland marked this pull request as ready for review November 19, 2024 13:47
@eikeland eikeland requested a review from a team November 19, 2024 13:48
@eikeland eikeland added the bug Something isn't working label Nov 19, 2024
@eikeland eikeland force-pushed the fix/person/clear-on-attribute-change branch from 3ff013a to 0319095 Compare November 20, 2024 08:34
@eikeland eikeland force-pushed the fix/person/clear-on-attribute-change branch from 0319095 to dc48a1c Compare November 20, 2024 09:05
@eikeland eikeland merged commit 4a69b85 into main Nov 20, 2024
6 of 8 checks passed
@eikeland eikeland deleted the fix/person/clear-on-attribute-change branch November 20, 2024 09:38
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asbjornhaland asbjornhaland asbjornhaland approved these changes

Assignees

@eikeland eikeland

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eikeland @asbjornhaland