Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/person/select/selectedperson null #1641

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

eikeland
Copy link
Contributor

@eikeland eikeland commented Oct 1, 2024

Changes in PersonSelectController

  • Updated the attrSelectPerson method to clear selectedIds when personData or selectedPerson is null.
  • Updated the clearInput method to reset azureId and upn properties.
  • Refactored the clear method to use #firePersonSelectEvent instead of directly dispatching the event.
  • Removed unnecessary comments and cleaned up the code.

Changes in PersonSelectElement

  • Added a new CSS class .selected-persons to hide the text input when a person is selected.
  • Updated the selectedPersonsTemplate method to be conditionally rendered based on the selectedIds size and isOpen state.
  • Adjusted the classMap to include the selected-persons class based on the selectedIds size and isOpen

Closes equinor/fusion#398

@eikeland eikeland added bug Something isn't working High priority labels Oct 1, 2024
@eikeland eikeland self-assigned this Oct 1, 2024
Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: e5ac0fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@equinor/fusion-wc-person Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eikeland eikeland marked this pull request as draft October 1, 2024 14:23
@eikeland eikeland marked this pull request as ready for review October 1, 2024 14:23
@eikeland eikeland requested a review from a team October 2, 2024 07:13
@eikeland eikeland merged commit 4aea53b into main Oct 2, 2024
7 of 9 checks passed
@eikeland eikeland deleted the fix/person/select/selectedperson-null branch October 2, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants