Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(person-card): fix placement to top if not enough space on bottom #1375

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

asbjornhaland
Copy link
Contributor

@asbjornhaland asbjornhaland commented Feb 12, 2024

Ref AB#48493
Fix equinor/fusion-react-components#1293
Fix equinor/fusion#255

@asbjornhaland asbjornhaland requested a review from odinr February 12, 2024 15:12
@asbjornhaland asbjornhaland self-assigned this Feb 12, 2024
Copy link

changeset-bot bot commented Feb 12, 2024

🦋 Changeset detected

Latest commit: 6abccb3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@equinor/fusion-wc-person Patch
@equinor/fusion-wc-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@asbjornhaland
Copy link
Contributor Author

@odinr Please review/test this in the storybook.

@asbjornhaland asbjornhaland force-pushed the fix/person-card/fix-placement branch from 4d0e968 to 6abccb3 Compare February 14, 2024 09:18
@asbjornhaland asbjornhaland marked this pull request as draft February 14, 2024 09:19
@asbjornhaland asbjornhaland marked this pull request as ready for review February 14, 2024 09:19
@asbjornhaland asbjornhaland merged commit 4875f40 into main Feb 14, 2024
7 of 9 checks passed
@asbjornhaland asbjornhaland deleted the fix/person-card/fix-placement branch February 14, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PersonListItem pop-over causes scrollbar
2 participants