Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/person/select/ux #1103

Merged
merged 9 commits into from
Nov 27, 2023
Merged

Feat/person/select/ux #1103

merged 9 commits into from
Nov 27, 2023

Conversation

eikeland
Copy link
Contributor

@eikeland eikeland commented Nov 10, 2023

  • Adding ui to person-select component with selected persons as person-list-item.
  • Adding variable to person-lit-item for setting background on items
  • moves element styles to own file
  • Controller property _listItems now holds the PersonInfo objects.

Copy link

changeset-bot bot commented Nov 10, 2023

🦋 Changeset detected

Latest commit: 2111d7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@equinor/fusion-wc-person Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eikeland eikeland self-assigned this Nov 10, 2023
@eikeland eikeland added the enhancement New feature or request label Nov 10, 2023
@eikeland eikeland force-pushed the feat/person/select/ux branch 2 times, most recently from 46522fa to 402ae3e Compare November 13, 2023 09:22
@eikeland eikeland force-pushed the feat/person/select/ux branch from 402ae3e to be243e8 Compare November 13, 2023 12:48
@eikeland eikeland force-pushed the feat/person/select/ux branch from be243e8 to 1a9c7c6 Compare November 13, 2023 12:53
@eikeland eikeland marked this pull request as ready for review November 13, 2023 12:57
@eikeland eikeland requested a review from a team November 13, 2023 12:57
@eikeland eikeland linked an issue Nov 13, 2023 that may be closed by this pull request
3 tasks
@eikeland eikeland requested a review from odinr November 16, 2023 13:48
@eikeland eikeland merged commit e550bfd into main Nov 27, 2023
5 checks passed
@eikeland eikeland deleted the feat/person/select/ux branch November 27, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

person components
2 participants