Make everest config imutable #9842
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #9842 will not alter performanceComparing Summary
|
DanSava
force-pushed
the
make-everest-config-imutable
branch
from
6db26e0 to
9bfd0a3
Compare
DanSava
added
release-notes:improvement
DanSava
force-pushed
the
make-everest-config-imutable
branch
from
211d755 to
b13f034
Compare
DanSava
force-pushed
the
make-everest-config-imutable
branch
from
b13f034 to
b734a69
Compare
yngve-sk
reviewed
Jan 23, 2025
| @@ -30,20 +30,22 @@ | |||
| ProgressBar = None # type: ignore | |||
|
|
|||
|
|
|||
| def export_with_progress(config: EverestConfig, export_ecl=True): | |||
| def export_with_progress( | |||
| config: EverestConfig, export_config: ExportConfig, export_ecl=True | |||
yngve-sk
reviewed
Jan 23, 2025
| @@ -503,9 +502,15 @@ def test_complete_status_for_normal_run_monitor( | |||
| "everest.bin.everest_script.everserver_status", | |||
| return_value={"status": ServerStatus.never_run, "message": None}, | |||
| ) | |||
| @patch("everest.simulator.everest_to_ert._everest_to_ert_config_dict", return_value={"SUMMARY": "*"}) | |||
| @patch( | |||
There was a problem hiding this comment.
The diff for this file in commit "Avoid everest export config overwriting" seems to be only an autoformatting + deletion of unused import?
yngve-sk
reviewed
Jan 23, 2025
| initial_guess=0, | ||
| variables=[{"name": "x"}, {"name": "y"}], | ||
| ) | ||
| config_dict = config.model_dump(exclude_none=True) |
There was a problem hiding this comment.
Nitpick/style suggestion: Would do ** notation to declare the object in one go rather than assigning props to the dict, similar for other cases assigning stuff to the config dict
|
Overall looks good, only some minor comments on style/commit structure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9788
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"')When applicable