Remove logging_level setter from Everest config

[DanSava]

Issue

Approach

• Remove the workaround to allow property setters for EverestConfig

(Screenshot of new behavior in GUI if applicable)

• PR title captures the intent of the changes, and is fitting for release notes.
• Added appropriate release note label
• Commit history is consistent and clean, in line with the contribution guidelines.
• Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n auto -m "not integration_test"')

When applicable

• When there are user facing changes: Updated documentation
• New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
• Large PR: Prepare changes in small commits for more convenient review
• Bug fix: Add regression test for the bug
• Bug fix: Create Backport PR to latest release

[codspeed-hq]

CodSpeed Performance Report

Merging #9806 will not alter performance

_{Comparing DanSava:make-everest-config-imutable (bd04a01) with main (fd06848)}

Summary

✅ 24 untouched benchmarks

[oyvindeide]

LGTM! Could we also set frozen? https://docs.pydantic.dev/latest/api/config/#pydantic.config.ConfigDict.frozen

[DanSava]

LGTM! Could we also set frozen? https://docs.pydantic.dev/latest/api/config/#pydantic.config.ConfigDict.frozen

I gave it a try but it seems we cannot right now. Some more work needs to be done before we can do it.

There are around 20 tests that are messing with an already instantiated config object that would need to be updated also the login in

ert/src/everest/config/everest_config.py

Lines 250 to 267 in fd06848

	@model_validator(mode="after")
	def validate_queue_system(self) -> Self: # pylint: disable=E0213
	if self.server is None:
	self.server = ServerConfig(queue_system=copy(self.simulator.queue_system))
	elif self.server.queue_system is None:
	self.server.queue_system = copy(self.simulator.queue_system)
	if (
	str(self.simulator.queue_system.name).lower() == "local"
	and str(self.server.queue_system.name).lower()
	!= str(self.simulator.queue_system.name).lower()
	):
	raise ValueError(
	f"The simulator is using local as queue system "
	f"while the everest server is using {self.server.queue_system.name}. "
	f"If the simulator is using local, so must the everest server."
	)
	self.server.queue_system.max_running = 1
	return self

Will need to be updated as well.

Do you want to have that as part of this issue?

[oyvindeide]

LGTM! Could we also set frozen? https://docs.pydantic.dev/latest/api/config/#pydantic.config.ConfigDict.frozen

I gave it a try but it seems we cannot right now. Some more work needs to be done before we can do it.

There are around 20 tests that are messing with an already instantiated config object that would need to be updated also the login in

ert/src/everest/config/everest_config.py

Lines 250 to 267 in fd06848

	@model_validator(mode="after")
	def validate_queue_system(self) -> Self: # pylint: disable=E0213
	if self.server is None:
	self.server = ServerConfig(queue_system=copy(self.simulator.queue_system))
	elif self.server.queue_system is None:
	self.server.queue_system = copy(self.simulator.queue_system)
	if (
	str(self.simulator.queue_system.name).lower() == "local"
	and str(self.server.queue_system.name).lower()
	!= str(self.simulator.queue_system.name).lower()
	):
	raise ValueError(
	f"The simulator is using local as queue system "
	f"while the everest server is using {self.server.queue_system.name}. "
	f"If the simulator is using local, so must the everest server."
	)
	self.server.queue_system.max_running = 1
	return self

Will need to be updated as well.

Do you want to have that as part of this issue?

Will leave it up to you, if you dont fix it here, will you create another issue and put it into todo?