Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Teaser link to reuse in text teaser, key numbers components and anywhere else if any. #2066 #2096

Merged
merged 7 commits into from
Feb 21, 2024

Conversation

millianapia
Copy link
Contributor

@millianapia millianapia commented Feb 2, 2024

There are other places where a refactor would be beneficial, but the structure is too different to benefit from reusing ReadMoreLink. Such as RelatedContent, CallToActions, Form, FiftyFiftyHero

@millianapia millianapia requested a review from a team as a code owner February 2, 2024 13:30
@millianapia millianapia self-assigned this Feb 2, 2024
Copy link
Contributor

@padms padms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ReadMoreLink can also be used in the 50-50 Hero Link

@millianapia
Copy link
Contributor Author

refactored the readmorelink so it could be used in more places

@millianapia millianapia requested a review from padms February 6, 2024 13:22
@BorghildSelle
Copy link
Contributor

BorghildSelle commented Feb 12, 2024

You could do something like;
export type ReadMoreLinkProps = {
action: LinkData
} & Pick<LinkProps, 'variant'>

@millianapia millianapia merged commit e1f5c92 into main Feb 21, 2024
4 checks passed
@millianapia millianapia deleted the malj/2066 branch February 21, 2024 09:07
@millianapia millianapia added the 🚀 ready to deploy Use this if issue is ready to be deployed label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 ready to deploy Use this if issue is ready to be deployed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants