Skip to content

Commit

Permalink
🐛 Fix featured content #2369 (#2370)
Browse files Browse the repository at this point in the history
* 🐛 set height to fit

* 🐛 fix headings
  • Loading branch information
BorghildSelle authored Jun 13, 2024
1 parent e5ede13 commit a68bfa5
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
6 changes: 3 additions & 3 deletions web/core/Typography/variants.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
const variants = {
heading: {
h1: 'text-slate-80 dark:text-white-100 text-3xl leading-earthy font-normal pb-8',
h2: 'text-slate-80 dark:text-white-100 text-2xl leading-cloudy font-normal pb-8',
h3: 'text-slate-80 dark:text-white-100 text-xl leading-inherit font-normal pb-0',
h1: 'text-slate-80 dark:text-white-100 text-3xl leading-earthy font-normal pb-11 my-0',
h2: 'text-slate-80 dark:text-white-100 text-2xl leading-cloudy font-normal pb-8 my-0',
h3: 'text-slate-80 dark:text-white-100 text-xl leading-inherit font-normal pb-0 my-0',
h4: 'text-slate-80 dark:text-white-100 text-lg leading-inherit font-normal pb-0',
h5: 'text-slate-80 dark:text-white-100 text-md leading-inherit font-normal pb-0',
h6: 'text-slate-80 dark:text-white-100 text-base leading-inherit font-normal pb-0',
Expand Down
2 changes: 1 addition & 1 deletion web/pageComponents/pageTemplates/shared/SharedTitle.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const SharedTitle = ({ sharedTitle, background }: SharedTitleProps) => {
value={sharedTitle}
as="h1"
variant="3xl"
className="py-8 px-layout-lg max-w-viewport mx-auto text-pretty"
className="py-11 my-0 px-layout-lg max-w-viewport mx-auto text-pretty"
/>
</BackgroundContainer>
)
Expand Down
5 changes: 3 additions & 2 deletions web/pageComponents/shared/siteMenu/FeaturedContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const FeaturedContent = ({ data }: Props) => {
//To destructure and get rid of 2 but keep rest
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const { routeContentType, type, ...restData } = data
const containerClassName = 'hidden xl:block pl-6 border-l border-autumn-storm-50 w-[20vw]'
const containerClassName = 'hidden xl:block pl-6 border-l border-autumn-storm-50 w-[16vw]'

if (isEvent(data)) {
return (
Expand All @@ -26,14 +26,15 @@ const FeaturedContent = ({ data }: Props) => {
} as EventCardData
}
hasSectionTitle={false}
className="h-fit"
/>
</div>
)
}

return (
<div className={containerClassName}>
<PromotionCard data={data} hasSectionTitle={false} />
<PromotionCard data={data} hasSectionTitle={false} className="h-fit" />
</div>
)
}
Expand Down

0 comments on commit a68bfa5

Please sign in to comment.