Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 Add selected color for SingleSelect menu items #926

Merged
merged 5 commits into from
Jan 7, 2025
Merged

💄 Add selected color for SingleSelect menu items #926

merged 5 commits into from
Jan 7, 2025

Conversation

mariush2
Copy link
Contributor

@mariush2 mariush2 commented Jan 7, 2025 •
edited by azure-boards bot
Loading

Userstory:

@mariush2 mariush2 requested a review from a team as a code owner January 7, 2025 07:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 98.05% (🎯 100%) 13021 / 13279
🔴 Statements 98.05% (🎯 100%) 13021 / 13279
🟢 Functions 100% (🎯 100%) 590 / 590
🔴 Branches 97.01% (🎯 100%) 2434 / 2509
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/atoms/hooks/useSelect.ts 91.34% 98.95% 100% 91.34% 124-125, 130, 132-133, 156, 190-191, 193-195, 209-211, 213-214, 216, 218-220
src/molecules/Select/GroupedSelectMenu.tsx 98.73% 94.73% 100% 98.73% 77
src/molecules/Select/ListSelectMenu.tsx 79.2% 90% 100% 79.2% 76-90, 97-106
src/molecules/Select/Select.styles.ts 100% 95% 100% 100%
src/molecules/Select/SelectMenuItem.tsx 100% 97.77% 100% 100%
Generated in workflow #1251 for commit c231027 by the Vitest Coverage Report Action

aslakihle
aslakihle previously approved these changes Jan 7, 2025
View reviewed changes
@mariush2 mariush2 requested a review from aslakihle January 7, 2025 09:05
aslakihle
aslakihle previously approved these changes Jan 7, 2025
View reviewed changes
@mariush2 mariush2 merged commit ddffb63 into main Jan 7, 2025
10 of 11 checks passed
@mariush2 mariush2 deleted the fix/singleselect-bg-color branch January 7, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslakihle aslakihle aslakihle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariush2 @aslakihle