-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example for cluster with AD on windows server #81
Conversation
55e2ec8
to
f5b604e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting failed in CI; could you run terraform fmt
and commit/push the changes?
e8cd7ec
to
cb5fb80
Compare
/rerun |
The linter CI has been very flaky. |
Linting is still failing, but I think that's only tangentially related to this PR. I've run this end-to-end and confirmed that, as long as I don't get an HTTP 422 while setting up AD, my cluster ends up in the desired state. In the future we can look at breaking down the null resource scripts into even smaller pieces and/or implementing sleeps or retries to reduce the occurrence of failed HTTP requests. |
fixes #67