Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example for cluster with AD on windows server #81

Merged
merged 17 commits into from
Aug 8, 2024

Conversation

aayushrangwala
Copy link
Contributor

fixes #67

variables.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed in CI; could you run terraform fmt and commit/push the changes?

@aayushrangwala aayushrangwala force-pushed the main branch 4 times, most recently from e8cd7ec to cb5fb80 Compare July 19, 2024 11:28
@aayushrangwala
Copy link
Contributor Author

/rerun

@displague
Copy link
Member

│ Error: Failed to install provider
│ 
│ Error while installing hashicorp/tls v4.0.5: open
│ /home/runner/.terraform.d/plugin-cache/registry.terraform.io/hashicorp/tls/4.0.5/linux_amd64/terraform-provider-tls_v4.0.5_x5:
│ text file busy

The linter CI has been very flaky.

outputs.tf Outdated Show resolved Hide resolved
@ctreatma
Copy link
Contributor

ctreatma commented Aug 8, 2024

Linting is still failing, but I think that's only tangentially related to this PR. I've run this end-to-end and confirmed that, as long as I don't get an HTTP 422 while setting up AD, my cluster ends up in the desired state.

In the future we can look at breaking down the null resource scripts into even smaller pieces and/or implementing sleeps or retries to reduce the occurrence of failed HTTP requests.

@ctreatma ctreatma merged commit 9770f2d into equinix-labs:main Aug 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples: Connectivity to Active Directory
3 participants