Improve <epidist> plotting method
#235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this PR in favour of #315. I will leave the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the plotting method for
<epidist>and<vb_epidist>objects by using {ggplot2}, {ggdist} and {gridExtras} R packages. The previous plotting methods used base R functionality. The new methods give a nicer default plot and allow for plots to be customised using the grammar of graphics layering offered by {ggplot2} and other gg derivative packages.This PR also adds a custom theme to the package to consistently produce plots with the same aesthetic and style.
The new functions are in a
R/plot.Rfile and the previous tests for plotting methods have been moved totestthat/test-plot.R.The README is updated to use the new plots.