Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding UI non-admin Dex test #398

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Adding UI non-admin Dex test #398

merged 2 commits into from
Nov 29, 2023

Conversation

mmartin24
Copy link
Contributor

@mmartin24 mmartin24 commented Nov 28, 2023 •
edited
Loading

@mmartin24
Adding non-admin dex test.
b300500 
Refactoring dex function
@mmartin24 mmartin24 added the area/qa Excluded from release notes. Quality assurance / Regression testing label Nov 28, 2023
@mmartin24 mmartin24 added this to the v1.11.0 milestone Nov 28, 2023
@mmartin24 mmartin24 self-assigned this Nov 28, 2023
@mmartin24 mmartin24 marked this pull request as ready for review November 28, 2023 12:11
@mmartin24 mmartin24 requested a review from thehejik November 28, 2023 12:11
@mmartin24 mmartin24 linked an issue Nov 28, 2023 that may be closed by this pull request
[Cypress] UI Test coverage for Dex non-admin users #396
Closed
thehejik
thehejik approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@thehejik thehejik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmartin24 mmartin24 merged commit e4f56ca into main Nov 29, 2023
1 check passed
@mmartin24 mmartin24 deleted the cypress/396-test-oidc-non-admin branch November 29, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehejik thehejik thehejik approved these changes

Assignees

@mmartin24 mmartin24

Labels
area/qa Excluded from release notes. Quality assurance / Regression testing
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.

[Cypress] UI Test coverage for Dex non-admin users
2 participants
@mmartin24 @thehejik