Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate Tekton Dashboard to cluster add-ons repo (#209) #210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Migrate Tekton Dashboard to cluster add-ons repo (#209) #210

wants to merge 1 commit into from

Conversation

daniil-nedostup
Copy link
Contributor

Pull Request

Description

Migrate the Tekton Dashboard Helm chart from the edp-tekton to the edp-cluster-add-ons repository

Fixes #209

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which improves an existing feature or documentation)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

@daniil-nedostup daniil-nedostup added the enhancement New feature or request label Jan 15, 2025
@daniil-nedostup daniil-nedostup self-assigned this Jan 15, 2025
@daniil-nedostup daniil-nedostup requested a review from a team as a code owner January 15, 2025 18:48
MykolaMarusenko
MykolaMarusenko reviewed Jan 20, 2025
View reviewed changes
clusters/core/addons/tekton-dashboard/templates/quicklink.yaml
@@ -0,0 +1,15 @@
{{ if .Values.dashboard.quicklink.enabled }}
{{ if .Values.dashboard.ingress.enabled }}
apiVersion: v2.edp.epam.com/v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets do not deploy ql, QL must be only in krci namespace

MykolaMarusenko
MykolaMarusenko reviewed Jan 20, 2025
View reviewed changes
clusters/core/apps/values.yaml
tekton-dashboard:
createNamespace: false
enable: false
namespace: krci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where we use this parameter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MykolaMarusenko MykolaMarusenko MykolaMarusenko left review comments

@SergK SergK SergK left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@daniil-nedostup daniil-nedostup

Labels
enhancement New feature or request
Projects
KubeRocketCI
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Tekton Dashboard to cluster add-ons repository
3 participants
@daniil-nedostup @SergK @MykolaMarusenko