sham non-trapping shim and ponyfill for cross-repo testing #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
changed the title
erights
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staged on #2679
Sham version of #2673 , where all the code in the new non-trapping package of #2673 has been moved into corresponding subdirectories of
ses. This is in order to fix the following:Currently, at Agoric/agoric-sdk#9201 we have the directive
which refers to #2675 that builds on #2673. However, it doesn't work with the following pervasive error:
This is likely because there is no
@endo/non-trappingpackage registered at npm, and there won't be until an endo with #2673 or something like it gets released. This PR works around that problem by not introducing the shim/ponyfill as a separate package, so that we can try the#endo-branch:directive, in order to see the problems that #2675 will cause for agoric-sdk, and correct them early.