Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient credentials scanning #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kmmanoj
Copy link

@kmmanoj kmmanoj commented Feb 22, 2020

This PR solves issue #46

What does this solve?

  • Data loss - the regex filtering sometimes does not extract the right word. In this fix, it does not regex filter from the text.
  • Moreover, it uses a more generalised search query.

How does it get?
It looks out sensitive words and gets the text. The text is put as it is in the file

@emtunc
Copy link
Owner

emtunc commented Mar 27, 2020

Thanks for the PR @kmmanoj - apologies it's taken this long to actually look at it. I'm going to see if I can further improve this as it wasn't catching some passwords in some tests of mine for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants