fixes: remove node_modules, fix url of the picture #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Thanks for the awesome example of machine learning in the browser! I found some bits of the project that may be improved very easy, that will allow clone project faster (regarding node_modules size), and remove some confusion when people try to run the project locally (wrong URL of the picture)
Changelog:
node_modulesfrom the project, to reduce the size, and add the folder to.gitignoredistfolder to.gitignoreto reduce the sizemona_lisa_with_frame_2.jpg->mona_lisa_with_frame_2.pngbecause in src folder are picture with png extension