refactor: remove C from HostResources #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
lulf
force-pushed
the
resource-refactor2
branch
from
922c8bf to
18f0468
Compare
|
/test |
|
@lulf Let me do a quick check if I can use your PR in |
* Refactor API to remove C: Controller from HostResources * Remove Clone + Copy on Stack and use it to hold the BleHost * Remove all 'internal' lifetime of elements within channels. Guarantee their lifetime in types that is handed ownership of elements from channels. * Simplify packet pool, removing the QoS flag. Issue #252
lulf
force-pushed
the
resource-refactor2
branch
from
18f0468 to
2e2e415
Compare
|
/test |
|
@lulf Type-checks in my code just fine! Huge improvement! (Yet to make it run of course.) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #252