Use Erlang's implementation of jaro distance, fix bugs #13369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabiwara
commented
Feb 25, 2024
lib/elixir/lib/string.ex
Outdated
Comment on lines
3073
to
3074
| # TODO: Remove me when we require Erlang/OTP 27+ | ||
| @jaro_module if :erlang.system_info(:otp_release) >= [?2, ?7], do: :string, else: :elixir_utils |
There was a problem hiding this comment.
I wasn't sure: is it enough to check the OTP version at compile time, or is there another preferred way?
There was a problem hiding this comment.
We can just always call the one in elixir_utils for now.
| @@ -999,6 +999,7 @@ defmodule StringTest do | |||
| assert String.jaro_distance("jon", "john") == 0.9166666666666666 | |||
| assert String.jaro_distance("jon", "jan") == 0.7777777777777777 | |||
| assert String.jaro_distance("семена", "стремя") == 0.6666666666666666 | |||
| assert String.jaro_distance("Sunday", "Saturday") == 0.7194444444444444 | |||
There was a problem hiding this comment.
Adding the example mentioned here
Comment on lines
+3069
to
3071
| def jaro_distance(string, string) when is_binary(string), do: 1.0 | ||
| def jaro_distance(_string, ""), do: 0.0 | ||
| def jaro_distance("", _string), do: 0.0 |
There was a problem hiding this comment.
I felt we could keep these optimizations since they weren't in the Erlang version, WDYT?
josevalim
approved these changes
Feb 26, 2024
|
@josevalim should I backport this one since it's a bug? Or not because of the vendored thing? |
|
Let's not backport this one, it seems a bit larger for a patch release and the bug has been there for several versions anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #13349
Copies the implementation of erlang/otp#7879