Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up the actions in the media details sheet. #3607

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

pixlwave
Copy link
Member

Probably best described by a screen recording:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-11.at.18.09.17.mp4

@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Dec 11, 2024
@pixlwave pixlwave requested a review from a team as a code owner December 11, 2024 18:10
@pixlwave pixlwave requested review from Velin92 and removed request for a team December 11, 2024 18:10
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against e89cd8a

Copy link

codecov bot commented Dec 11, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
882 2 880 0
View the top 1 failed tests by shortest run time
PreviewTests test_timelineMediaPreviewDetailsView()
Stack Traces | 1.23s run time
failed - Snapshot "Image" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-pseudo.Image.png"
@+
"file:.../tmp/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-pseudo.Image.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9949837 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)
View the full list of 1 ❄️ flaky tests
PreviewTests test_userProfileScreen()

Flake rate in main: 13.16% (Passed 132 times, Failed 20 times)

Stack Traces | 2.46s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9031372 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixlwave pixlwave merged commit 88b5426 into develop Dec 12, 2024
10 checks passed
@pixlwave pixlwave deleted the doug/media-preview-handle-actions branch December 12, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants