Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where the pinned items banner could overlay the composer. #3441

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 23, 2024

This PR puts the overlay on just the timeline, and not the timeline + composer. Probably not a final fix given the clipping that takes place, but good enough for now. Closes #3411.

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-10-23.at.17.21.02.mp4

@pixlwave pixlwave added the pr-bugfix for bug fix label Oct 23, 2024
@pixlwave pixlwave requested a review from a team as a code owner October 23, 2024 16:22
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 23, 2024 16:22
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against cb5f5a1

Copy link

Copy link

codecov bot commented Oct 23, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
847 2 845 0
View the full list of 2 ❄️ flaky tests
PreviewTests test_loginScreen()

Flake rate in main: 26.91% (Passed 296 times, Failed 109 times)

Stack Traces | 6.95s run time
failed - Snapshot "matrix.org" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_loginScreen-iPhone-16-pseudo.matrix-org.png"
@+
"file:.../tmp/PreviewTests/test_loginScreen-iPhone-16-pseudo.matrix-org.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8482666 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
RoomScreenViewModelTests testPinnedEventsBanner()

Flake rate in main: 21.92% (Passed 57 times, Failed 16 times)

Stack Traces | 11.8s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple 👍

@pixlwave pixlwave merged commit 2b82959 into develop Oct 24, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/fix-banner-composer-layout branch October 24, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On small screens (iPhone SE), you can't cancel edits in rooms with pinned msgs
2 participants