Show a verification badge on the Room Member/User Profile screens. #3427
Conversation
pixlwave
changed the title
Generated by 🚫 Danger Swift against e72347d |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
| } | ||
| case .failure(let error): | ||
| MXLog.warning("Failed to find member: \(error)") | ||
| actionsSubject.send(.openUserProfile) |
There was a problem hiding this comment.
I vaguely remember what this was about, may be we should add a comment.
| @@ -204,4 +204,6 @@ protocol ClientProxyProtocol: AnyObject, MediaLoaderProtocol { | |||
|
|
|||
| func pinUserIdentity(_ userID: String) async -> Result<Void, ClientProxyError> | |||
| func resetIdentity() async -> Result<IdentityResetHandle?, ClientProxyError> | |||
|
|
|||
| func userIdentity(_ userID: String) async -> Result<UserIdentity?, ClientProxyError> | |||
There was a problem hiding this comment.
I feel like this is missing a verb 🙃
There was a problem hiding this comment.
Yeah it's weird isn't it. It is no different to sessionVerificationController() -> SessionVerificationControllerProtocol but it reads more weirdly. Maybe I'll make it userIdentity(for: userID).
pixlwave
force-pushed
the
doug/verified-status
branch
from
599574e to
e72347d
Compare
|
|
Ignoring enterprise tests as that same one is fine on normal. And SC is right these 2 screens are very similar, but thats fine for now. |
This PR makes 2 changes to the Room Member and User Profile screens:
Requires matrix-org/matrix-rust-sdk#4142, closes #3413