generated from element-hq/.github
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First round of icon updates. #2076
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
force-pushed
the
doug/2002-icons
branch
from
November 13, 2023 13:16
7abfc0e
to
f02c9c6
Compare
Generated by 🚫 Danger Swift against 2a3a452 |
Update Compound too.
pixlwave
force-pushed
the
doug/2002-icons
branch
from
November 13, 2023 16:11
f02c9c6
to
96038d8
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
pixlwave
requested review from
nimau and
callumu
and removed request for
a team
November 13, 2023 16:21
Velin92
reviewed
Nov 13, 2023
UnitTests/__Snapshots__/PreviewTests/test_appLockSettingsScreen.Face-ID.png
Show resolved
Hide resolved
Velin92
reviewed
Nov 13, 2023
Velin92
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some questions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #2002. I'll tackle the Settings List separately as it needs more work. Also updates Compound too.