Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First round of icon updates. #2076

Merged
merged 4 commits into from
Nov 13, 2023
Merged

First round of icon updates. #2076

merged 4 commits into from
Nov 13, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 13, 2023

First part of #2002. I'll tackle the Settings List separately as it needs more work. Also updates Compound too.

User Menu Room Attachments Menu Reply Views
Screenshot 2023-11-13 at 11 16 31 am Screenshot 2023-11-13 at 4 15 16 pm Screenshot 2023-11-13 at 12 33 30 pm
Room Context Menu User Details Edit Screen
Simulator Screenshot - iPhone 14 - 2023-11-13 at 16 16 03 Simulator Screenshot - iPhone 14 - 2023-11-13 at 16 17 01

Copy link

github-actions bot commented Nov 13, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 2a3a452

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave marked this pull request as ready for review November 13, 2023 16:21
@pixlwave pixlwave requested a review from a team as a code owner November 13, 2023 16:21
@pixlwave pixlwave requested review from nimau and callumu and removed request for a team November 13, 2023 16:21
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some questions

@pixlwave pixlwave merged commit 4257c20 into develop Nov 13, 2023
5 checks passed
@pixlwave pixlwave deleted the doug/2002-icons branch November 13, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants