Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the reldbg profile default for SDK builds again #1941

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

stefanceriu
Copy link
Member

Following matrix-org/matrix-rust-sdk#2765 we need to switch back to reldbg which not contains debug symbols but also doesn't crash

Revert "Debug is no longer crashing as of matrix-rust-sdk/pull/2595time to make it the default again so that debugging works properly"

This reverts commit eb9c69c.

…time to make it the default again so that debugging works properly"

This reverts commit eb9c69c.
@stefanceriu stefanceriu requested a review from a team as a code owner October 23, 2023 13:27
@stefanceriu stefanceriu requested review from alfogrillo and removed request for a team October 23, 2023 13:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 8947520

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5356a56) 69.51% compared to head (8947520) 69.42%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1941      +/-   ##
===========================================
- Coverage    69.51%   69.42%   -0.09%     
===========================================
  Files          499      499              
  Lines        33880    33875       -5     
  Branches     16435    16433       -2     
===========================================
- Hits         23550    23517      -33     
- Misses        9723     9755      +32     
+ Partials       607      603       -4     
Flag Coverage Δ
unittests 54.50% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ElementX/Sources/Application/AppSettings.swift 96.77% <100.00%> (+1.25%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanceriu stefanceriu merged commit 68442d5 into develop Oct 23, 2023
9 checks passed
@stefanceriu stefanceriu deleted the stefan/reldbgDefault branch October 23, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants