Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DSWaveformImage to 14.1.1 #1935

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Update DSWaveformImage to 14.1.1 #1935

merged 1 commit into from
Oct 23, 2023

Conversation

alfogrillo
Copy link
Contributor

This PR updates DSWaveformImage to 14.1.1 which is not compatible with Xcode 14 (undoing this fix).

@alfogrillo alfogrillo requested a review from a team as a code owner October 23, 2023 07:56
@alfogrillo alfogrillo requested review from Velin92 and removed request for a team October 23, 2023 07:56
@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 62e47ca

stefanceriu
stefanceriu approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@alfogrillo alfogrillo enabled auto-merge (squash) October 23, 2023 08:26
@alfogrillo alfogrillo force-pushed the alfogrillo/update-waveform-image branch from 7161170 to 62e47ca Compare October 23, 2023 10:38
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alfogrillo alfogrillo merged commit 6d577ea into develop Oct 23, 2023
5 checks passed
@alfogrillo alfogrillo deleted the alfogrillo/update-waveform-image branch October 23, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

@Velin92 Velin92 Awaiting requested review from Velin92 Velin92 is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfogrillo @stefanceriu