Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken snapshots. #1924

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Update broken snapshots. #1924

merged 1 commit into from
Oct 19, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 19, 2023

Fix some snapshots that were broken by the changes in DesignKit/Compound.

UI tests run is here: https://github.com/vector-im/element-x-ios/actions/runs/6573925042

@pixlwave pixlwave requested a review from a team as a code owner October 19, 2023 11:28
@pixlwave pixlwave requested review from nimau and removed request for a team October 19, 2023 11:28
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 8588fc7

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (99c2878) 69.09% compared to head (8588fc7) 69.89%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1924      +/-   ##
===========================================
+ Coverage    69.09%   69.89%   +0.80%     
===========================================
  Files          483      472      -11     
  Lines        32995    32435     -560     
  Branches     16018    15758     -260     
===========================================
- Hits         22797    22671     -126     
+ Misses        9612     9186     -426     
+ Partials       586      578       -8     
Flag Coverage Δ
uitests 32.52% <ø> (-1.11%) ⬇️
unittests 54.43% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 15b5b44 into develop Oct 19, 2023
9 of 10 checks passed
@pixlwave pixlwave deleted the doug/fix-ui-tests branch October 19, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants