-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat backup - first part #1913
Chat backup - first part #1913
Conversation
Generated by 🚫 Danger Swift against 6e26202 |
1baae96
to
9e7aaba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah, great work!
.../Screens/SecureBackup/SecureBackupKeyBackupScreen/SecureBackupKeyBackupScreenViewModel.swift
Outdated
Show resolved
Hide resolved
.../Screens/SecureBackup/SecureBackupKeyBackupScreen/SecureBackupKeyBackupScreenViewModel.swift
Outdated
Show resolved
Hide resolved
.../Screens/SecureBackup/SecureBackupKeyBackupScreen/SecureBackupKeyBackupScreenViewModel.swift
Outdated
Show resolved
Hide resolved
.../Screens/SecureBackup/SecureBackupKeyBackupScreen/SecureBackupKeyBackupScreenViewModel.swift
Outdated
Show resolved
Hide resolved
...eens/SecureBackup/SecureBackupRecoveryKeyScreen/SecureBackupRecoveryKeyScreenViewModel.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/Settings/SettingsScreen/View/SettingsScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/SecureBackup/SecureBackupControllerProtocol.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, (plus the changes we went over this morning).
ElementX.xcodeproj/project.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/HomeScreen/View/HomeScreenUserMenuButton.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/SecureBackup/SecureBackupScreen/View/SecureBackupScreen.swift
Outdated
Show resolved
Hide resolved
42d28e1
to
fe3b843
Compare
fe3b843
to
6e26202
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Some UI comments:
|
This PR implements the screens and mocked logic for:
The logic inside the SecureBackupController is currently mocked and goes like this:
Designs here https://www.figma.com/file/0MMNu7cTOzLOlWb7ctTkv3/Element-X?type=design&node-id=12124-116601&mode=design&t=RLlU4wtjLjUt2xrO-0
Touches:
#1899
#1900
#1901
#1901