Add waveform placeholder

element-hq · Oct 19, 2023 · d7b37be · d7b37be
1 parent c6b04b7
commit d7b37be
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 10 deletions.
diff --git a/ElementX.xcodeproj/project.pbxproj b/ElementX.xcodeproj/project.pbxproj
@@ -6100,7 +6100,7 @@
 			repositoryURL = "https://github.com/dmrschmidt/DSWaveformImage";
 			requirement = {
 				kind = upToNextMinorVersion;
-				minimumVersion = 14.0.0;
+				minimumVersion = 14.1.0;
 			};
 		};
 		61916C63E3F5BD900F08DA0C /* XCRemoteSwiftPackageReference "KeychainAccess" */ = {

diff --git a/ElementX.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/ElementX.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -30,8 +30,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/dmrschmidt/DSWaveformImage",
       "state" : {
-        "revision" : "730021fa5bab91aae2f77d90e1c1c8c4985c0756",
-        "version" : "14.0.0"
+        "revision" : "6a4c99a8ab2d2a03f42de21fb8777172ebbcccb1",
+        "version" : "14.1.0"
       }
     },
     {

diff --git a/...es/Timeline/TimelineItems/Items/Messages/VoiceMessages/VoiceMessageRoomPlaybackView.swift b/...es/Timeline/TimelineItems/Items/Messages/VoiceMessages/VoiceMessageRoomPlaybackView.swift
@@ -111,7 +111,6 @@ struct VoiceMessageRoomPlaybackView: View {
                         })
             }
         }
-        .animation(.elementDefault, value: playerState.fileURL)
         .onChange(of: dragState) { newDragState in
             switch newDragState {
             case .inactive:
@@ -164,15 +163,20 @@ struct VoiceMessageRoomPlaybackView: View {
         if let url = playerState.fileURL {
             WaveformView(audioURL: url,
                          configuration: .init(style: .striped(.init(color: .black, width: waveformLineWidth, spacing: waveformLinePadding)),
-                                              verticalScalingFactor: 1.0))
+                                              verticalScalingFactor: 1.0),
+                         placeholder: { estimatedWaveformView })
                 .progressMask(progress: playerState.progress)
         } else {
-            EstimatedWaveformView(lineWidth: waveformLineWidth,
-                                  linePadding: waveformLinePadding,
-                                  waveform: playerState.waveform,
-                                  progress: playerState.progress)
+            estimatedWaveformView
         }
     }
+
+    private var estimatedWaveformView: some View {
+        EstimatedWaveformView(lineWidth: waveformLineWidth,
+                              linePadding: waveformLinePadding,
+                              waveform: playerState.waveform,
+                              progress: playerState.progress)
+    }
 }
 
 private enum DragState: Equatable {

diff --git a/project.yml b/project.yml
@@ -119,7 +119,7 @@ packages:
     branch: 0.0.1
   DSWaveformImage:
     url: https://github.com/dmrschmidt/DSWaveformImage
-    minorVersion: 14.0.0
+    minorVersion: 14.1.0