Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore dependency that are not third-party licenses to us. #4122

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 7, 2025

Content

Ignore dependency that are not third-party licenses to us.

(note: iOS PR: element-hq/element-x-ios#3661)

Motivation and context

We do not need to display those licenses.

Screenshots / GIFs

licensee will exclude all dependencies with groupId io.element.android, as we can see in the generated file (diff before / after):

image

Tests

  • Navigate to Settings / About / Open source license
  • Observe that the dependencies form io.element.android are not listed anymore. You can filter with Compound for instance and you will get empty result.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner January 7, 2025 16:35
@bmarty bmarty requested review from ganfra and removed request for a team January 7, 2025 16:35
@bmarty bmarty added the PR-Misc For other changes label Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (271f032) to head (7b5481f).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4122   +/-   ##
========================================
  Coverage    83.28%   83.28%           
========================================
  Files         1885     1885           
  Lines        49096    49096           
  Branches      5764     5764           
========================================
  Hits         40888    40888           
  Misses        6139     6139           
  Partials      2069     2069           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NwZpcH

Copy link

sonarqubecloud bot commented Jan 7, 2025

@bmarty bmarty merged commit fc42dca into develop Jan 8, 2025
28 checks passed
@bmarty bmarty deleted the feature/bma/ignoreOurDependencies branch January 8, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants