Refactor some JetStream helper code, add support for specifying JetStream domain #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ream domain Signed-off-by: Neil Alexander <[email protected]>
Signed-off-by: Neil Alexander <[email protected]>
neilalexander
force-pushed
the
neil/jetstream
branch
from
4391466 to
f5a45e8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3485 +/- ##
==========================================
- Coverage 49.39% 49.38% -0.02%
==========================================
Files 524 524
Lines 59737 59751 +14
==========================================
- Hits 29507 29506 -1
- Misses 26748 26760 +12
- Partials 3482 3485 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
S7evinK
reviewed
Jan 2, 2025
Comment on lines
+88
to
+92
| } else if err.Error() == "nats: Server Shutdown" { | ||
| // The server is shutting down, but we'll rely on reconnect | ||
| // behaviour to try and either connect us to another node (if | ||
| // clustered) or to reconnect when the server comes back up. | ||
| continue |
Signed-off-by: Neil Alexander <[email protected]>
|
Sytest is unhappy until #3471 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should gracefully handle some more potential errors that the consumer fetches can return with retries, as well as setting some client settings for reconnects etc when using an external NATS Server.
Also allow specifying the JetStream domain in case of a leafnode scenario and better manage client reuse across Dendrite. And also update NATS Server to 2.10.24 for good measure.
This code is backported from Harmony.
Signed-off-by: Neil Alexander [email protected]